----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/ -----------------------------------------------------------
(Updated Dec. 5, 2013, 7:01 p.m.) Review request for Plasma. Changes ------- Use QString instead of QUrl for the identifier so we have two different identifiers for different urls for the same host (e.g. http://kde.org and kde.org). The current engine does this way. Repository: kde-workspace Description (updated) ------- I replaced KUrl by QUrl and KStandardDirs by QStandardPaths. Also I cleanup includes. The url given in input could be absolute or relative but not local, then I used QUrl::fromUserInput(). Diffs (updated) ----- plasma/generic/dataengines/favicons/favicons.cpp 2eae673 plasma/generic/dataengines/favicons/favicons.h 79565bf plasma/generic/dataengines/favicons/faviconprovider.cpp bc72a66 plasma/generic/dataengines/favicons/faviconprovider.h 1f370f9 plasma/generic/dataengines/CMakeLists.txt 3e94325 plasma/generic/dataengines/favicons/CMakeLists.txt 4af0f14 Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing (updated) ------- If I try to fetch several favicons an empty image is returned, except the first one which contains a valid favicon. Thanks, Andrea Scarpino
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
