----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112812/#review40353 -----------------------------------------------------------
Ship it! Looks good, thanks for the patch, just fix the whitespace, then it's good to go. Do you have a Git account? In that case, please push to KDE/4.11, master and frameworks-scratch branches. plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml <http://git.reviewboard.kde.org/r/112812/#comment29774> one space to much to line up with the previous line, same for other added lines. - Sebastian Kügler On Sept. 19, 2013, 11:44 a.m., Benedikt Gollatz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112812/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 11:44 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Use type description sort order in the devicenotifier applet when > non-removable devices are configured to be displayed. This avoids apparently > random sort order (by device engine population timestamp) and unneccessary > ListView sections. The problem becomes apparent if other types of devices > besides simple storage volumes are configured in /etc/fstab, like for example > network mounts. > > Fixes bug #324459. > > > This addresses bug 324459. > http://bugs.kde.org/show_bug.cgi?id=324459 > > > Diffs > ----- > > > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml > 9b6132e95bf12cac726699fd40850a6b1d3513b6 > > Diff: http://git.reviewboard.kde.org/r/112812/diff/ > > > Testing > ------- > > Works for me using KDE 4.10.5 packaged with Fedora 19. > > > Thanks, > > Benedikt Gollatz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
