> On May 3, 2013, 8:53 p.m., Marco Martin wrote: > > Ship It! > > Martin Gräßlin wrote: > has this review been merged yet? > > Aaron J. Seigo wrote: > not to my knowledge, no. i'm neck deep in meetings today if someone else > feels like doing it :) > > Martin Gräßlin wrote: > @Alexey: could you please upload the diff as a "git format-patch"ed one? > This would keep your authorship on the patch.
I'm not going to merge this patch: it blocks the highlight in general and for the case which is actually wanted it seems not to be needed. At least when I have a fullscreen window the panel unhide trigger is not shown. This might be related to a change in KWin for better layering of fullscreen windows. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review31964 ----------------------------------------------------------- On March 22, 2013, 5:53 p.m., Alexey Shmalko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106110/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 5:53 p.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > Make autohide panel do not intercept events in fullscreen app. > > I changed PanelView::createUnhideTrigger() to check whether current active > application is in fullscreen mode. So in fullscreen applications panel will > be always hidden. > > > This addresses bug 217560. > http://bugs.kde.org/show_bug.cgi?id=217560 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp 7713740 > > Diff: http://git.reviewboard.kde.org/r/106110/diff/ > > > Testing > ------- > > Tested with patched gentoo ebuild. Works fine. > > > Thanks, > > Alexey Shmalko > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
