----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25310 -----------------------------------------------------------
This review has been submitted with commit f74729bd26caff383ad5227df36a4a7f2f2608a3 by Emil Sedgh to branch master. - Commit Hook On Jan. 12, 2013, 3:46 p.m., Emil Sedgh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108316/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2013, 3:46 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Audio player controller has the ability to search through Amarok's collection. > This patch uses 'arturl' property of Amarok's reply to show album art in > KRunner results. > > Some considerations: > arturl sent by Amarok has file:// prefix which QIcon does not understand. I > used QString::remove(0,7) to remove the prefix but it seems hackish. Are > there better ways of fixing this issue? > I get many warnings when I run krunner: "QPixmap: It is not safe to use > pixmaps outside the GUI thread". How should I fix it? > > > Diffs > ----- > > runners/audioplayercontrol/CMakeLists.txt 665add6 > runners/audioplayercontrol/audioplayercontrolrunner.cpp 75afb75 > > Diff: http://git.reviewboard.kde.org/r/108316/diff/ > > > Testing > ------- > > Works fine if there's some album art. > Reverts to audio-x-generic icon if no arturl is defined. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/108316/s/1013/ > > > Thanks, > > Emil Sedgh > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
