----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107743/#review23923 -----------------------------------------------------------
Ship it! I wanted to try to avoid to have that, it ruins balance and adds extra information not so much useful when has to be understood very quickly in that couple of seconds the message is displayed. but whatever, i won't block it ;) One sensible sensible use case could be if enough applications have malformed messages that have useful information only in the title but not in the body. - Marco Martin On Dec. 23, 2012, 6:16 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107743/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2012, 6:16 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > New qml notification doesn't show summary for last popup notification. This > patch add summary back. > > > This addresses bug 307670. > http://bugs.kde.org/show_bug.cgi?id=307670 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > e63526b > > plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml > 9e4345a > > Diff: http://git.reviewboard.kde.org/r/107743/diff/ > > > Testing > ------- > > No problem here. Looks ok. > > > Screenshots > ----------- > > current appearance > http://git.reviewboard.kde.org/r/107743/s/899/ > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
