> On Dec. 16, 2012, 10:09 p.m., Kai Uwe Broulik wrote: > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml, > > line 181 > > <http://git.reviewboard.kde.org/r/107743/diff/1/?file=99464#file99464line181> > > > > Seems to have no effect here, and font shouldn't be bold since it is > > not bold in the notification list. > > Xuetian Weng wrote: > If you check the code, the list actually use bold. > > NotificationDelegate.qml L113 > > I also have no idea why it does not work..
I wouldn't have bold there... why? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107743/#review23571 ----------------------------------------------------------- On Dec. 16, 2012, 11:17 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107743/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 11:17 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > New qml notification doesn't show summary for last popup notification. This > patch add summary back. > > > This addresses bug 307670. > http://bugs.kde.org/show_bug.cgi?id=307670 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > e63526b > > plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml > 9e4345a > > Diff: http://git.reviewboard.kde.org/r/107743/diff/ > > > Testing > ------- > > No problem here. Looks ok. > > > Screenshots > ----------- > > current appearance > http://git.reviewboard.kde.org/r/107743/s/899/ > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
