----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106742/#review20679 -----------------------------------------------------------
one small API issue, otherwise looks great. plasmate/packagemodel.cpp <http://git.reviewboard.kde.org/r/106742/#comment16328> missing space between } and else plasmate/packagemodel.cpp <http://git.reviewboard.kde.org/r/106742/#comment16329> wrong indentation level plasmate/packagemodel.cpp <http://git.reviewboard.kde.org/r/106742/#comment16330> this is a bit too specific to a single file: if we change the structure in the future, will we add a new method for each new file like mainconfigxml? instead, i'd recommend changing this to: bool PackageModel::fileExists(const QString &key) const and call it with package->fileExists("mainconfigxml") - Aaron J. Seigo On Oct. 5, 2012, 4:25 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106742/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 4:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch refactors the package model making it "smarter", > > so the package model will > * create only the necessary files and dirs for a package > * a dir is empty it will be auto deleted > * the package model shows the description of the files(if it exists) instead > of their names > * if a main.xml file doesn't exist, the model will have an entry like "New > Configuration XML", > the "New..." entry won't be there. > > > Diffs > ----- > > plasmate/editors/editpage.h 8cc5fab > plasmate/editors/editpage.cpp 91f6bce > plasmate/mainwindow.cpp 8e87b7b > plasmate/packagemodel.h 43b9df5 > plasmate/packagemodel.cpp 67cc0f4 > > Diff: http://git.reviewboard.kde.org/r/106742/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
