----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106742/#review19979 -----------------------------------------------------------
plasmate/editors/editpage.cpp <http://git.reviewboard.kde.org/r/106742/#comment15833> Should be done line the lines 147-152 plasmate/editors/editpage.cpp <http://git.reviewboard.kde.org/r/106742/#comment15834> why empty line? plasmate/packagemodel.cpp <http://git.reviewboard.kde.org/r/106742/#comment15832> Should it be better if you do something like return QFile::exists(m_package->filePath("mainconfigxml"); - Antonis Tsiapaliokas On Oct. 5, 2012, 4:25 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106742/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 4:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch refactors the package model making it "smarter", > > so the package model will > * create only the necessary files and dirs for a package > * a dir is empty it will be auto deleted > * the package model shows the description of the files(if it exists) instead > of their names > * if a main.xml file doesn't exist, the model will have an entry like "New > Configuration XML", > the "New..." entry won't be there. > > > Diffs > ----- > > plasmate/editors/editpage.h 8cc5fab > plasmate/editors/editpage.cpp 91f6bce > plasmate/mainwindow.cpp 8e87b7b > plasmate/packagemodel.h 43b9df5 > plasmate/packagemodel.cpp 67cc0f4 > > Diff: http://git.reviewboard.kde.org/r/106742/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
