-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review14996
-----------------------------------------------------------



plasma/desktop/shell/plasmaapp.cpp
<http://git.reviewboard.kde.org/r/105319/#comment11790>

    I think this leaks :-S
    
    
    lib kactivities has a method for this, you may as well just use that.
    
    KActivities::Controller activityController;
    QString currentActivity = activityController.currentActivity();
    
    then add ${KACTIVITIES_LIBRARY} to your target_link_libraries in 
CMakeLists.txt
    
    


- David Edmundson


On June 22, 2012, 2:07 a.m., Varun Herale wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> -----------------------------------------------------------
> 
> (Updated June 22, 2012, 2:07 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> -------
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to