----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/#review14979 -----------------------------------------------------------
plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11773> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11774> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11775> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11776> incorrect identation the correct coding style for if is the following if (condition) { //somecode //here you need 4 spaces } else { //somecode //here you need 4 spaces } plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11780> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11777> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11778> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11779> incorrect identation plasma/desktop/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/105319/#comment11781> same here. In general, you need to leave 4 spaces instead of 2 and the if should always have bracers, even if it is only one line - Antonis Tsiapaliokas On June 21, 2012, 7:15 p.m., Varun Herale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105319/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 7:15 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch is for hosting a dbus-interface that can be used to load any > installed wallpaper plugin onto current desktop containment. In case of > default "image" plugin, the path to the image can also be sent which will > change the wallpaper. > > > Diffs > ----- > > plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 > plasma/desktop/shell/plasmaapp.h 6ae0c89 > plasma/desktop/shell/plasmaapp.cpp 7abd8fc > > Diff: http://git.reviewboard.kde.org/r/105319/diff/ > > > Testing > ------- > > Tested on different activities and made sure it works for per-virtual desktop > containment. > > Haven't tested on a system with multiple screens though, as I don't have > access to one. Could someone please test for that ? > > > Thanks, > > Varun Herale > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
