----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104716/ -----------------------------------------------------------
Review request for Plasma. Description ------- Hello, this branch contains QML bindings for KLocale. I believe that is the time to review it here. Diffs ----- plasma/declarativeimports/locale/CMakeLists.txt PRE-CREATION plasma/declarativeimports/locale/calendarsystem.h PRE-CREATION plasma/declarativeimports/locale/calendarsystem.cpp PRE-CREATION plasma/declarativeimports/locale/locale.h PRE-CREATION plasma/declarativeimports/locale/locale.cpp PRE-CREATION plasma/declarativeimports/locale/localebindingsplugin.h PRE-CREATION plasma/declarativeimports/locale/localebindingsplugin.cpp PRE-CREATION plasma/declarativeimports/locale/qmldir PRE-CREATION plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml PRE-CREATION plasma/declarativeimports/locale/tests/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104716/diff/ Testing ------- there is a plasmoid in kde-runtime/plasma/declarativeimports/locale/tests in which I have exported every property/q_invokable. Some issues that I will like to mention a. there is tests/contents/code/klocaleqmltest.qml I believe that it should be tests/contents/ui/main.qml b. the test plasmoid is exported as org.kde.klocaleqmltest it should be org.kde.example.localetest c. Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want the bindings to influence the core functionality. what do you think? Thanks, Giorgos Tsiapaliwkas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
