----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ -----------------------------------------------------------
(Updated March 30, 2012, 6:57 p.m.) Review request for KDE Runtime and Plasma. Changes ------- Fix the code that moves files and make it create sub-folders for each file being moved so that files with the same name but different parent folder do not clash. Description ------- When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added. This addresses bug 296808. http://bugs.kde.org/show_bug.cgi?id=296808 Diffs (updated) ----- service/jobs/nepomuk/Move.h 8a8afd1 service/jobs/nepomuk/Move.cpp 2248768 Diff: http://git.reviewboard.kde.org/r/104417/diff/ Testing ------- Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image". Thanks, Lamarque Vieira Souza
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel