> On March 21, 2012, 9:20 a.m., Marco Martin wrote: > > let's merge then fix all the things that may remain ok? > > (if you are rady to quickly fix issues as they come in, because many will > > report ;) > > Viranch Mehta wrote: > Yep, I'm ready. > > Sebastian Kügler wrote: > I'd prefer if we wait with merging until all issues are fixed, there are > still quite a few regressions here, from my testing: > > - discharge percentage isn't shown at all > - the top right graphic in the popup is missing > - information on the RHS doesn't match labels on the LHS > - the Hibernate button is shown here, while the machine only supports > sleep (works fine with old applet) > - s/Powermanagement/Power Management > - Lots of runtime warnings, especially about dereferencing missing > datasources > > > Sebastian Kügler wrote: > I'm testing from the plasma/viranch/powermanagementservices branch, does > that one contain the latest state of the art?
Yes, the plasma/viranch/powermanagementservices branch contains the latest QML applet (including the following fixes): (I'm not updating the diff here anymore. Will do it when applet is ready.) - discharge percentage isn't shown at all - information on the RHS doesn't match labels on the LHS Fixed both. These were due to some serious mistakes in merge conflicts in last commit (my apologies) - the Hibernate button is shown here, while the machine only supports sleep (works fine with old applet) - Lots of runtime warnings, especially about dereferencing missing datasources Fixed both. Had forgotten to add "Sleep States" in connectedSources. - s/Powermanagement/Power Management Fixed this in the i18nc comment of the label "Power management enabled:". Did I miss elsewhere? - the top right graphic in the popup is missing Added, and working. - Viranch ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11683 ----------------------------------------------------------- On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104226/ > ----------------------------------------------------------- > > (Updated March 20, 2012, 9:44 p.m.) > > > Review request for Plasma. > > > Description > ------- > > I fixed the QML battery monitor to be fairly usable and this diff merges it > to master. > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt 2dedcb2 > plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION > plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION > plasma/generic/applets/batterymonitor/README.txt PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz > PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION > plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION > plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION > plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 > plasma/generic/dataengines/powermanagement/powermanagementengine.cpp > 5572fcb > plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 > > plasma/generic/dataengines/powermanagement/powermanagementservice.operations > ad1301f > > Diff: http://git.reviewboard.kde.org/r/104226/diff/ > > > Testing > ------- > > Applet and dataengine both tested and work fine. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/104226/s/482/ > > > Thanks, > > Viranch Mehta > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
