----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11667 -----------------------------------------------------------
Screenshot: <http://git.reviewboard.kde.org//r/104226/#scomment40> This looks kind bad. There should be a certain amount of padding. - Vishesh Handa On March 20, 2012, 9:44 p.m., Viranch Mehta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104226/ > ----------------------------------------------------------- > > (Updated March 20, 2012, 9:44 p.m.) > > > Review request for Plasma. > > > Description > ------- > > I fixed the QML battery monitor to be fairly usable and this diff merges it > to master. > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt 2dedcb2 > plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION > plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION > plasma/generic/applets/batterymonitor/README.txt PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz > PRE-CREATION > plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION > plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > PRE-CREATION > plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION > plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION > plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2 > plasma/generic/dataengines/powermanagement/powermanagementengine.cpp > 5572fcb > plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 > plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 > > plasma/generic/dataengines/powermanagement/powermanagementservice.operations > ad1301f > > Diff: http://git.reviewboard.kde.org/r/104226/diff/ > > > Testing > ------- > > Applet and dataengine both tested and work fine. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/104226/s/482/ > > > Thanks, > > Viranch Mehta > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel