> On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote: > > A few remarks inline. I'm not really happy with it UI wise yet, and I'd > > like to see a screenshot of it in action. Especially that row of iconitems > > can already grow quite wide, imagine hibernate and suspend both available, > > and the whole thing in Russian: you need a wide screen display for it ;) > > > > So needs some work. > > Dario Freddi wrote: > Agreed, that's why I submitted this review :P unfortunately I wrongly > pushed this commit to master, but well --' Any suggestions on where to place > it, considering also the combo box is going to go away? > > Aaron J. Seigo wrote: > "inhibit" and "uninhibit" are things we understand as developers; i'm not > sure many run-of-the-mill computer users will. it would probably be better to > find some descriptive language for this that describes what is actually does, > which is essentially "suspend power management features". > > it should also not go alng with hibernate and suspend since those put the > entire machine into an "off" state. the control for inhibiting pm should be > closer to what it really controls, currently the drop down menu of choices. > > it might make sense to simply note: "Power management features are on." > with a button next to it change that. or a checkbox solution something like: > > Battery: 39% (discharging) > AC Adapter: Not plugged in > Current strategy: Power saving > Power Management: [ x ] Enabled > Screen brightness: [============== o===========] > > > when the "Enabled" checkbox is unchecked, the current strategy label > would grey out, reflecting it's disabled state. would require some user > testing, but would seem more obvious that what is currently there to me. > > btw: what will the combo box be replaced with? or why is it determined to > not be of use anymore? is simple inhibition going to replace switching > between profiles, under the assumption that one always wants either power > management as a function of power available or else they want a full > performance profile with no power management happening? (that's something i > think might make sense; though i haven't done much fact gathering to support > the idea ...) > >
Seems sensible - even though the power strategy does not really apply anymore as it's just dependent on the battery state. But I like the check box, I'll resubmit the patch with something similar. About the combo box issue; man, I guess you've been missing out on what happened yesterday on plasma-devel and k-c-d :P The flame-less version is here: http://drfav.wordpress.com/2011/10/02/forge-sprint-2011-power-management-and-its-future/ - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102757/#review7016 ----------------------------------------------------------- On Oct. 2, 2011, 2:48 p.m., Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102757/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2011, 2:48 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Description > ------- > > As the title says. The feature works, but I'm wondering if we can make it > look better. Any suggestions warmly appreciated :) > > > Diffs > ----- > > plasma/generic/applets/battery/battery.h d696014 > plasma/generic/applets/battery/battery.cpp c3a4f58 > > Diff: http://git.reviewboard.kde.org/r/102757/diff/diff > > > Testing > ------- > > > Thanks, > > Dario Freddi > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
