----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102757/#review7016 -----------------------------------------------------------
A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the whole thing in Russian: you need a wide screen display for it ;) So needs some work. plasma/generic/applets/battery/battery.cpp <http://git.reviewboard.kde.org/r/102757/#comment6189> c/p error :) plasma/generic/applets/battery/battery.cpp <http://git.reviewboard.kde.org/r/102757/#comment6188> Fishy ... I suspect lots of people going "WTF" when seeing a play/stop button... Should probably be something in the same style as the logout/shutdown/suspend/... buttons plasma/generic/applets/battery/battery.cpp <http://git.reviewboard.kde.org/r/102757/#comment6190> Elsewhere, we use pushbuttons, which communicate better if something's enabled or not. Changing button meaning / text is usually not a very good idea, but having a button pressed or not makes it better visible. - Sebastian Kügler On Oct. 2, 2011, 2:48 p.m., Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102757/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2011, 2:48 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Description > ------- > > As the title says. The feature works, but I'm wondering if we can make it > look better. Any suggestions warmly appreciated :) > > > Diffs > ----- > > plasma/generic/applets/battery/battery.h d696014 > plasma/generic/applets/battery/battery.cpp c3a4f58 > > Diff: http://git.reviewboard.kde.org/r/102757/diff/diff > > > Testing > ------- > > > Thanks, > > Dario Freddi > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
