> On May 6, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote: > > should i push the new diff? > > Aaron J. Seigo wrote: > yes; when it's marked with ShipIt you can push. sometimes there are some > additional comments, but those are going to be detail items at that point, > and you don't need to re-submit the diff before pushing :) > > Giorgos Tsiapaliwkas wrote: > sorry for my late respawn but i was busy with a greek foss event. > > Actually there is an issue with the patch.If i add 5 projects and then > delete them all from the list,plasmate will still think that i have 5 > projects because plasmate counts the projects that are located in > "~/.kde/share/apps/plasmate" directory. > > Remember that we had discussed,about a destroy button which will delete > the projects from the list and from the system. > > what should i do?
a destroy button would be a good addition (separate patch/commit though, please). and it should probably rely on the count of items shown rather than the number of directories on disk for this feature. p.s. i hope the f/oss event was enjoyable! :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101243/#review3175 ----------------------------------------------------------- On April 28, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101243/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 6:54 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > hello, > > the patch renames the "more projects" to "manage projects" if the projects > are 0>= and <=4 and renames it to "manage and more project" for >5. > > We decided to make this patch after a discussion at the plasma-devel with > aseigo. > > p.s.:i have git access i just need my patch to be reviewed. > > > Diffs > ----- > > startpage.cpp c29f85f > > Diff: http://git.reviewboard.kde.org/r/101243/diff > > > Testing > ------- > > compiled and worked,with no issues. > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
