> On May 6, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote: > > should i push the new diff?
yes; when it's marked with ShipIt you can push. sometimes there are some additional comments, but those are going to be detail items at that point, and you don't need to re-submit the diff before pushing :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101243/#review3175 ----------------------------------------------------------- On April 28, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101243/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 6:54 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > hello, > > the patch renames the "more projects" to "manage projects" if the projects > are 0>= and <=4 and renames it to "manage and more project" for >5. > > We decided to make this patch after a discussion at the plasma-devel with > aseigo. > > p.s.:i have git access i just need my patch to be reviewed. > > > Diffs > ----- > > startpage.cpp c29f85f > > Diff: http://git.reviewboard.kde.org/r/101243/diff > > > Testing > ------- > > compiled and worked,with no issues. > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
