----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5679/#review8290 -----------------------------------------------------------
for me is okay, even if an obscured password directly in the config file isn't great... some time ago it did already this thing, why was it removed? svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp <http://svn.reviewboard.kde.org/r/5679/#comment8566> here we use brackets also for one line ifs if () { } else { } - Marco On 2010-10-21 15:18:12, Mohit Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5679/ > ----------------------------------------------------------- > > (Updated 2010-10-21 15:18:12) > > > Review request for Plasma. > > > Summary > ------- > > It was a bug posted on bugs.kde.org, > Here is the link: https://bugs.kde.org/show_bug.cgi?id=242377 > Well it did stored the password in config file but never read it. > So i just added the reading feature and reloaded the history. > > > Diffs > ----- > > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp > 1187571 > > Diff: http://svn.reviewboard.kde.org/r/5679/diff > > > Testing > ------- > > I tested it on kdeplasma-addons revision 1187571 > > > Thanks, > > Mohit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
