-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3914/#review7746
-----------------------------------------------------------


should this review request be marked as rejected? (is this even possible?)

- Beat


On 2010-05-07 17:58:06, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3914/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 17:58:06)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this little class (that probably have to stay private) is a little central 
> place for widget to see how they should behave. with touchscreen  some things 
> have to change for everybody, like refusing hover events, always.
> other widgets will have to change even more, for instance ScrollWidget will 
> have to replace the scrollbars with some simple scroll indicators that 
> appears over the contents and only while animating.
> it's now done with a simpe config file, it would be cool doing it completely 
> dinamically, and actually by querying the hardware. but i don't thiunk it 
> exists any sane system to hgave reliably thi kind of informations (like if a 
> poiter devie is a mouse otr a touchscreen) so for now it would have to be 
> manually configured.
> It kinda sucks, but i think it's a quite important feature anyways, quite 
> crucial for touchscreens, and would be still easy to change if is going to 
> stay private for now
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1123761 
>   /trunk/KDE/kdelibs/plasma/private/inputtypewatcher.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/private/inputtypewatcher_p.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp 1123761 
> 
> Diff: http://svn.reviewboard.kde.org/r/3914/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to