> On 2010-05-07 20:13:04, Aaron Seigo wrote: > > the idea is sound, but the implementation leaves me queasy :) this really > > ought to be implemented somewhere else (e.g. Qt). keeping a list of every > > widget we have around is not great ... also, i wonder if this really needs > > to be runtime configurable, or can we assume a static hardware profile? or > > is one of the design requirements to support switching between a tablet > > mode and a laptop mode? (that is actually probably quite valid...) > > > > but as this is not a trivial thing and given where we are in the release > > cycle, can we put this off until 4.6?
yes, better postpone it. by the way, yes, i think a runtime switching capability would be the little thing we have more - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3914/#review5505 ----------------------------------------------------------- On 2010-05-07 17:58:06, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3914/ > ----------------------------------------------------------- > > (Updated 2010-05-07 17:58:06) > > > Review request for Plasma. > > > Summary > ------- > > this little class (that probably have to stay private) is a little central > place for widget to see how they should behave. with touchscreen some things > have to change for everybody, like refusing hover events, always. > other widgets will have to change even more, for instance ScrollWidget will > have to replace the scrollbars with some simple scroll indicators that > appears over the contents and only while animating. > it's now done with a simpe config file, it would be cool doing it completely > dinamically, and actually by querying the hardware. but i don't thiunk it > exists any sane system to hgave reliably thi kind of informations (like if a > poiter devie is a mouse otr a touchscreen) so for now it would have to be > manually configured. > It kinda sucks, but i think it's a quite important feature anyways, quite > crucial for touchscreens, and would be still easy to change if is going to > stay private for now > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1123761 > /trunk/KDE/kdelibs/plasma/private/inputtypewatcher.cpp PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/inputtypewatcher_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp 1123761 > > Diff: http://reviewboard.kde.org/r/3914/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
