> On 2010-09-16 11:20:34, Sebastian Kügler wrote: > > One small issue with i18n context left, otherwise it's good to go in (from > > my point of view, better wait for annma to mark it as ship it as well).
Thanks. I will do it right away :) > On 2010-09-16 11:20:34, Sebastian Kügler wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 88 > > <http://svn.reviewboard.kde.org/r/5362/diff/4/?file=36015#file36015line88> > > > > i18n context should be more useful. > > Anne-Marie Mahfouf wrote: > I agree with Sebas, ship it and thanks for looking in this issue! > As for the context help for translators, maybe we can put i18nc("Text > written on default picture", "Dropped folder is empty. Please drop a folder > with image(s)"); Thanks Anne-Marie :) - Sujith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7637 ----------------------------------------------------------- On 2010-09-16 03:54:44, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5362/ > ----------------------------------------------------------- > > (Updated 2010-09-16 03:54:44) > > > Review request for Plasma. > > > Summary > ------- > > This diff will give the user meaningful message when a folder is dropped to > the frame applet and if it doesn't contain image(s). > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 > > Diff: http://svn.reviewboard.kde.org/r/5362/diff > > > Testing > ------- > > This has been tested. > > > Thanks, > > Sujith > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
