----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7623 -----------------------------------------------------------
- You forgot to remove the class SlideShow; and #include "slideshow.h" from the Picture class - The message is not so good "Folder that is dropped is empty. Please drop a folder with image(s)". Maybe "Dropped folder is empty. Please drop a folder with image(s)" An English speaker can improve this. - There should not be the 2 arrows on the picture (the next and previous ones that only make sense on a slideshow). If you then drop a picture in it the 2 arrows stay. This seems to be a bug that existed before the patch though (the arrows stay after a slideshow) - Anne-Marie On 2010-09-15 18:45:47, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5362/ > ----------------------------------------------------------- > > (Updated 2010-09-15 18:45:47) > > > Review request for Plasma. > > > Summary > ------- > > This diff will give the user meaningful message when a folder is dropped to > the frame applet and if it doesn't contain image(s). > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 > > Diff: http://svn.reviewboard.kde.org/r/5362/diff > > > Testing > ------- > > This has been tested. > > > Thanks, > > Sujith > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
