On Sun, Apr 20, 2025 at 1:50 AM Linus Jahn <l...@kaidan.im> wrote: > On Sat, 19 Apr 2025 13:23:59 +0100 > David Edmundson <da...@davidedmundson.co.uk> wrote: > > > >Realistically merge requests shouldn't be proposed until people are > > >ready to get something reviewed and merged in... > > > > That's not realistic with how it is on the frontlines. The earlier we > > share feedback the better, and reviews can take many many iterations. > > > > There's a "CI_MERGE_REQUEST_APPROVED" variable which seems to match > > what I think we're after? > > Then we're running it only when the reviewer thinks it's ready. > > > > David > > And there's also CI_MERGE_REQUEST_DRAFT, so another option would also > be to at least disable some jobs for draft MRs. >
Looks to be used very inconsistently within KWin at least, but it is something I guess. I've changed the default behaviour globally now ( https://invent.kde.org/sysadmin/ci-utilities/-/commit/07133f846f000ff05d9a87b49b0f47bf90614b52) with jobs on draft merge requests now requiring manual runs. I would still like to see the KWin developers review the list of jobs they have active though in response to my initial mail and follow up to that initial mail as that has been completely ignored to date. > > Linus > Cheers, Ben
