On Sun, Apr 20, 2025 at 12:24 AM David Edmundson <da...@davidedmundson.co.uk> wrote:
> >Realistically merge requests shouldn't be proposed until people are ready > to get something reviewed and merged in... > > That's not realistic with how it is on the frontlines. The earlier we > share feedback the better, and reviews can take many many iterations. > > There's a "CI_MERGE_REQUEST_APPROVED" variable which seems to match > what I think we're after? > Then we're running it only when the reviewer thinks it's ready. > The pipeline templates are globally shared among all our projects, so not sure only running on approval is the best course of action here. It might work for bigger projects where you are waiting for others to review and then will have to rebase before it merges but it will break workflows where people open merge requests to validate their work passes CI before merging or where reviews are put up for a maintainer to merge if they're happy with it (due to a smaller number of core developers, often just one or two). > David > Cheers, Ben
