Hi, KDE SC 4.5 will arrive soon, so I wonder if someone could give me feedbacks on this review.
Thanks :-) Luc. Le lundi 12 juillet 2010 19:13:34 Iamluc, vous avez écrit : > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4519/ > ----------------------------------------------------------- > > (Updated 2010-07-12 17:13:34.681342) > > > Review request for Plasma. > > > Changes > ------- > > Third version with Fredrik changes. > Less changes, but we still need to call update() in listingCompleted() to > show the message. > > The icon has been removed. > > > Summary > ------- > > Hello, > > This patch add a Plasma::Label with text "This folder is empty." in > Folderview's Popup when the folder is empty. > > The related bug number in kde bugzilla is 201542. > > Luc > > > This addresses bug 201542. > https://bugs.kde.org/show_bug.cgi?id=201542 > > > Diffs (updated) > ----- > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373 > > Diff: http://reviewboard.kde.org/r/4519/diff > > > Testing > ------- > > Delete/add files several times. The label disappears/appears correctly. > > > Screenshots > ----------- > > folderview empty folder > http://reviewboard.kde.org/r/4519/s/444/ > version 2 > http://reviewboard.kde.org/r/4519/s/455/ > > > Thanks, > > Iamluc _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
