----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4548/ -----------------------------------------------------------
(Updated 2010-07-12 20:10:03.795472) Review request for Plasma. Changes ------- I updated the apidox; changed the every three minute timer to a single shot timer when data is updated, renamed some files and variables, and moved others into private to not break binary compatibility. Summary ------- DataEngines can mark or unmark their sources to be cached with void DataEngine::setEnableCache(const QString &source, bool cache). If the DataEngine has implemented their own source by inheriting DataContainer, then DataContainer::setEnableCache(bool cache) will work. Diffs (updated) ----- /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1147556 /trunk/KDE/kdelibs/plasma/data/operations/storage.operations PRE-CREATION /trunk/KDE/kdelibs/plasma/datacontainer.h 1147556 /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1147556 /trunk/KDE/kdelibs/plasma/dataengine.h 1147556 /trunk/KDE/kdelibs/plasma/dataengine.cpp 1147556 /trunk/KDE/kdelibs/plasma/private/datacontainer_p.h 1147556 /trunk/KDE/kdelibs/plasma/private/dataengine_p.h 1147556 /trunk/KDE/kdelibs/plasma/private/storage_p.h PRE-CREATION Diff: http://reviewboard.kde.org/r/4548/diff Testing ------- I have tested it with the microblogging dataengine/plasmoid. Thanks, Brian
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
