davidre added a comment.

  I don't get how saving as a png fails if we have the image as QImage.

INLINE COMMENTS

> kded_potd.cpp:9
> +{
> +    consumer = new Plasma::DataEngineConsumer();
> +    engine = consumer->dataEngine(QStringLiteral("potd"));

still leaks

> kded_potd.cpp:28
> + */
> +void PotdModule::dataUpdated(const QString& sourceName, const 
> Plasma::DataEngine::Data& data)
> +{

This method can be removed it's not referenced anywhere.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, davidre, broulik
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to