broulik added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in iconapplet.cpp:435
> According to the kservice docs KService::serviceByStorageId() param is        
> "the storage id or desktop-file path of the service", so I guess that's why 
> it works.

but "desktop file path" is what we're doing. what I believe is happening that 
you're actually launching the original file, not the one the icon uses.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to