ahmadsamir added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:435
> But why would `serviceByStorageId` work then?
> Looks like this needs to be `KService::Ptr(new KService(m_localPath))` then?

According to the kservice docs KService::serviceByStorageId() param is  "the 
storage id or desktop-file path of the service", so I guess that's why it works.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to