ngraham added inline comments. INLINE COMMENTS
> cblack wrote in breezestyle.cpp:5608 > mmm, not sure how I feel about this Yeah we shouldn't be overriding this. `documentMode` is something that the widget itself can have set depending on the context. AFAIK the plan is to use `documentMode` to determine the style: - `documentMode: true` means it's an "editable" tab (e.g. an open document in Okular, a view in Konsole, or a folder in Dolphin that should look distinctly tab-like, as with this new design, etc) `documentMode: false` means it's a "non-editable" tab used to switch between tool views (e.g. the tabbed sidebars in Okular or Gwenview, a tabbed view in a settings window, etc) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
