cblack added inline comments.

INLINE COMMENTS

> breezehelper.cpp:1276
>          QRectF frameRect( rect );
> -        qreal radius( frameRadius( PenWidth::NoPen, -1 ) );
> +        qreal radius( 0 ); //frameRadius( PenWidth::NoPen, -1 ) );
>  

You should remove code rather than commenting it out

> breezestyle.cpp:5447
>          // render focus line
> -        _helper->renderFocusLine( painter, textRect, focusColor );
> +        //_helper->renderFocusLine( painter, textRect, focusColor );
>  

ditto

> breezestyle.cpp:5546
>  
> -                rect.adjust( 0, 1, 0, 0 );
> +                rect.adjust( 0, - 1, 0, 0 );
>                  if( isFirst ) corners |= CornerBottomLeft;

Excess space, should be `-1`

> breezestyle.cpp:5608
>              const auto tabWidget = ( widget && widget->parentWidget() ) ? 
> qobject_cast<const QTabWidget *>( widget->parentWidget() ) : nullptr;
> -            documentMode |= ( tabWidget ? tabWidget->documentMode() : true );
> +            documentMode = true; //|= ( tabWidget ? 
> tabWidget->documentMode() : true );
>  

mmm, not sure how I feel about this

> breezestyle.cpp:5610
>  
> -            color = 
> (documentMode&&!isQtQuickControl&&!hasAlteredBackground(widget)) ? 
> palette.color( QPalette::Window ) : _helper->frameBackgroundColor( palette );
> +            color = 
> /*(documentMode&&!isQtQuickControl&&!hasAlteredBackground(widget)) ?*/ 
> palette.color( QPalette::Window ); //: _helper->frameBackgroundColor( palette 
> );
>  

or this

> breezestyle.cpp:5623
>          // outline
> -        const auto outline( selected ? _helper->alphaColor( palette.color( 
> QPalette::WindowText ), 0.25 ) : QColor() );
> +        const auto outline( true ? _helper->alphaColor( palette.color( 
> QPalette::WindowText ), 0.25 ) : QColor() );
> +

... or this

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

Reply via email to