arfrever added inline comments. INLINE COMMENTS
> CMakeLists.txt:23 > > -find_package(PipeWire) > -set_package_properties(PipeWire PROPERTIES > - TYPE OPTIONAL > - PURPOSE "Required for screencast portal" > -) > - > -find_package(GBM) > -set_package_properties(GBM PROPERTIES > - TYPE OPTIONAL > - PURPOSE "Required for screencast portal" > -) > - > -find_package(Epoxy) > -set_package_properties(Epoxy PROPERTIES DESCRIPTION "libepoxy" > - URL "https://github.com/anholt/libepoxy"; > - TYPE OPTIONAL > - PURPOSE "Required for screencast portal" > -) > - > -if (PipeWire_FOUND AND GBM_FOUND AND Epoxy_FOUND) > - set (SCREENCAST_ENABLED true) > +option(DISABLE_PIPEWIRE_SUPPORT "Disable PipeWire support. PipeWire is > needed for screen sharing and remote desktop" OFF) > +if(DISABLE_PIPEWIRE_SUPPORT) Could this option be renamed to positively sounding option enabled by default? (And word `SUPPORT` seems redundant.) option(ENABLE_PIPEWIRE "Enable PipeWire support. PipeWire is needed for screen sharing and remote desktop" ON) REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH pipewire-required REVISION DETAIL https://phabricator.kde.org/D28677 To: jgrulich, #plasma, apol Cc: arfrever, apol, asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
