jgrulich marked 2 inline comments as done.
jgrulich added inline comments.

INLINE COMMENTS

> asturmlechner wrote in CMakeLists.txt:23-24
> maybe make it a proper cmake option?

I made it a cmake option. I have never used it before so please check if it's 
correct.

> asturmlechner wrote in CMakeLists.txt:51-52
> This is odd, is it a leftover or did you forget to add an actual KF5 
> dependency here?

It was a leftover, removed now.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Reply via email to