pereira.alex added a comment.

  In D28057#645140 <https://phabricator.kde.org/D28057#645140>, @ngraham wrote:
  
  > I still don't think we need three values in the config file for only two 
view modes.
  
  
  well ... I can use only one value in config file, but then the user loses the 
previous selected size when he changes modes ( list to icon and back ).
  also i could instead of 2 other values, use a "previous value of other mode", 
but that might not make much sense/readability for anyone else maybe ( and 
loses  meaning if there ever is more than 2 modes ).
  
  keeping modes selected sizes ( when switching modes ), this is the best i 
think. the rest of the code of the plasmoid, only looks at the default size 
value, and i think its best than filling the code with conditionals. also keeps 
backwards compability.
  
  the only promise I can make is that i will be maintaining what i change, so 
if i can figure out a better way i improve it.
  
  sorry if things aren't good enough, please believe that it isn't out of 
laziness or lack of interest.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to