bport added a comment.
In D28461#639022 <https://phabricator.kde.org/D28461#639022>, @ngraham wrote: > I get a compile error: > > /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: > /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: ‘isDefaults’ is not a member of ‘KCModuleLoader’ > 154 | d->isDefault = KCModuleLoader::isDefaults(d->item); > | ^~~~~~~~~~ > > > Does this have un-merged dependencies? If so, you can mark them in Phab by adding the text `Depends on D12345` (but the actual patch ID, not D12345 <https://phabricator.kde.org/D12345> :) ) in the Summary section. Ok I will add it I thought setting a parent revision on the right sidebar was enough REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart