abetts added a comment.
If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have the possibility to see that changes have been made. I am not sure that I like the implementation. I have some questions. What will you do when all of them are changed in some way? Will the entire kcm list show an icon indicating change? If you think about it, KDE is the DE of changes and options. I feel all of these are going to show some kind of change, that could be overwhelming. At the end of the day, is it necessary? Wouldn't this be something that probably works best by having it in the reset/defaults button? Also, these icons indicate change, if you click on the item and then land in a kcm that doesn't present more clues as to what changed, then you are left with the default action to click defaults or reset on the kcm anyway. There doesn't seem to be much more value there. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart
