dfaure added a comment.
Looks good to me, but please wait until D28367 <https://phabricator.kde.org/D28367> and D28268 <https://phabricator.kde.org/D28268> land, since they change the API of ApplicationLauncherJob for KServiceAction. I do not think KActivities::ResourceInstance::notifyAccessed should be done from KIO, which doesn't depend on KActivities (and I would like to keep it that way). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28347 To: broulik, #plasma, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart