hpereiradacosta added a comment.
I finally got some time to look at the code. Some minor comments below (compiler warnings) Also there is a problem with menubar text color when option is disabled. Here at least it is still set to the decoration color, leading to invisible text with default breeze color scheme. See: F8199046: Screenshot_20200325_155010.png <https://phabricator.kde.org/F8199046> F8199048: Screenshot_20200325_155034.png <https://phabricator.kde.org/F8199048> INLINE COMMENTS > breezehelper.cpp:50 > + _config( std::move( config ) ), > + _decorationConfig( new InternalSettings() ), > + _kwinConfig( KSharedConfig::openConfig("kwinrc") ), compiler complains about wrong initialization order > breezestyle.cpp:4935 > + > + bool Style::drawMenuBarEmptyAreaControl( const QStyleOption* option, > QPainter* painter, const QWidget* widget ) const > + { same remark about option being unused REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
