ngraham added inline comments. INLINE COMMENTS
> kmaterka wrote in StatusNotifierItem.qml:90 > Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin > and `KIconLoader` has 5% of icon size - another inconsistency. > What about 'always round when multiplying by a non-integer value'? I don't > know exactly why, but AFAIK not-rounded number can cause inconsistent > behavior in QML. > @ngraham can you give a word of explanation? Yes, when you have a positional value that isn't an integer, the engine can end up positioning the item on half-pixels and everything looks blurry. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik, mart, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart