kmaterka added inline comments. INLINE COMMENTS
> davidre wrote in StatusNotifierItem.qml:90 > Hmm to me it looks it doesn't even have an margin. Or am I reading ` > p.drawPixmap(QRect(m_iconPixmap.width()-size, m_iconPixmap.height()-size, > size, size), overlay->pixmap(size, size), QRect(0,0,size,size));` wrong? Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin and `KIconLoader` has 5% of icon size - another inconsistency. What about 'always round when multiplying by a non-integer value'? I don't know exactly why, but AFAIK not-rounded number can cause inconsistent behavior in QML. @ngraham can you give a word of explanation? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik, mart, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
