cblack added inline comments. INLINE COMMENTS
> hpereiradacosta wrote in breezetoolsareamanager.cpp:133 > Did you check that this chunk of code (changing the contents margins of the > QMainWindow) has any effect ? I had my doubt so I changed the margin to 100 > instead of 1, added a printout to make sure that this line of code is called, > then ran dolphin and > 1/ the code is indeed called > 2/ it changes nothing, on dolphin, okular, ... > if you can confirm, then just drop it. > > (in fact, I don't understand the login in the first place: why would you need > to add one pixel on top of everything in the QMainWindow ?) This only triggers when the window has no items in the tools area—it's used in conjunction with line 878 of breezestyle.cpp in order to render a border at the top of the window. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
