sitter added inline comments.

INLINE COMMENTS

> pino wrote in opengl.cpp:210
> qPrintable is wrong when passing paths to native C functions; use 
> QFile::encodeName instead

Is that also true for paths that are only ascii? Specifically path is a /dev 
node.

> pino wrote in opengl.cpp:230-233
> why not just use QDirIterator instead, so it combines dir listing and 
> filtering?

Hadn't even occured to me. It's a good thought though, I'll get on it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

Reply via email to