gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:9
> +
> +add_library(
> +    colorreload-gtk-module SHARED

add_library(colorreload-gtk-module SHARED
      reloader.c
  )

> CMakeLists.txt:14
> +
> +target_link_libraries(
> +    colorreload-gtk-module PRIVATE

Sorry, this is a nitpick, but could you please make this look like this:

  target_link_libraries(colorreload-gtk-module
    PRIVATE
      ${GLIB_LIBRARIES}
      ${GTK_LIBRARIES}

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to