gikari requested changes to this revision. gikari added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) Would you mind setting this at the parent CMakeLists.txt? > CMakeLists.txt:2 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) > + Would you mind making this as a subproject? > CMakeLists.txt:10 > + > +add_library ( colorreload-gtk-module > + SHARED Also, could you remove spaces around parentaces to match the CMake style with the one, that is in kded and kconf_update directories? > CMakeLists.txt:14 > + > +target_link_libraries( > + colorreload-gtk-module Isn't the PUBLIC/PRIVATE modifiers a good modern CMake practice? The same for target_include_directories REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28076 To: cblack, #plasma, gikari Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
