apol added a comment.
Both the isServiceRegistered and the env changes make sense to me. INLINE COMMENTS > startup.cpp:232 > connect(loginSound, &NotificationThread::finished, loginSound, > &NotificationThread::deleteLater); > loginSound->start();}); > Unrelated change. > startup.cpp:421 > + m_process->setArguments(args); > + m_process->setProcessEnvironment(env); > + Maybe it would make sense to do the merging of envs here? This way we only set when it's necessary. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27457 To: apol, #plasma, davidedmundson, fvogt Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
