fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startup.cpp:211
> StartProcessJob I think is fine. It's not set, so it'll inherit.
> 
> It's the extra arg to StartServiceJob that has potential to wipe the env.
> 
> It defaults to empty
> 
> and we do     p->setEnvironment(m_env);

> StartProcessJob I think is fine. It's not set, so it'll inherit.

It is set in line 440, which defaults to empty (line 90 in the header) as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Reply via email to