broulik added inline comments.

INLINE COMMENTS
> ndavis wrote in ToolTipInstance.qml:151
> I suppose it depends on whether or not you think PC3 toolbuttons should 
> reflect the look and size of Qt Widget toolbar buttons by default. Toolbar 
> buttons in Qt widgets use 22px icons (equivalent to 
> units.iconSizes.smallMedium).

I'm merely stating that this is a behavioral change from PC2 to PC3 and 
realistically everyone using PC3 so far has manually hardcoded the icon sizes 
to some value.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Reply via email to