----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/ -----------------------------------------------------------
(Updated 2010-04-19 19:43:39.677273) Review request for Plasma and Alessandro Diaferia. Changes ------- I know this is getting quite big now. i'll take a step back now and wait for some comments on this part while I attack something different like the infobar or dataengines. I'll reply to Alessandro's comments in the coming days. This adds: - background states. you can now watch and listen to videos/pictures and music in parallel - the zones in the controller now actually work concerning the layout part When testing, please only load media files that match the type of the state you currently look at. i.e. videos in video mode (via playlist), pictures in picture mode (directly via browser), music in musicmode (via playlist) Things to discuss: The way we have everything now, is PMC flexible enough for future expansion? Summary ------- The state calsses now have less functions. Only one for connections and one for configuration. The first one is only called once at PMC initialization, the second one is called at each state switch. Some connections can conflict between states. Those are connected at entry() and disconnected at exit(). Thanks to Alessandr's work we can now also configure the layout from within the state class (I only had to correct some namespace stuff in the medialayout class, I hope that was correct). This patch also gets basic functionality back. The modes are not really useful yet. Video mode is the most complete and can be used to view everything at th moment. Next step: Clean this up a bit Think about subclassing plasma widgets to get the widget type into the widget. This is necessary to be able to tell the controller to layout into zones. Start work on information bar. Diffs (updated) ----- trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/config.ui 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1113370 Diff: http://reviewboard.kde.org/r/3552/diff Testing ------- Lots and lots. Seems to be quite slow, but I think that is a problem in the player. It always iterates over all the queue even if it should only show a picture. Thanks, Christophe _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
