----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3552/ -----------------------------------------------------------
(Updated 2010-04-15 17:55:32.714768) Review request for Plasma and Alessandro Diaferia. Changes ------- In addition to the previous: - Setting the volume now works - Initial work on having a zone information that is sent to the controller along with the widgets. The controller should have different nested layouts, but this causes PMC to crash so I commented that code out - The picturestate now lets you view single pictures by clicking on them in the browser. No switching to other pictures in the same directory yet in fullscreen mode - Fixed some connections in the videostate - BUG: Clicking on play in videostatemode doesn't start playing the playlist yet. - BUG: clicking on pause while playing something hides the controller. It should only do thet when the mouse leaves the controller Summary ------- The state calsses now have less functions. Only one for connections and one for configuration. The first one is only called once at PMC initialization, the second one is called at each state switch. Some connections can conflict between states. Those are connected at entry() and disconnected at exit(). Thanks to Alessandr's work we can now also configure the layout from within the state class (I only had to correct some namespace stuff in the medialayout class, I hope that was correct). This patch also gets basic functionality back. The modes are not really useful yet. Video mode is the most complete and can be used to view everything at th moment. Next step: Clean this up a bit Think about subclassing plasma widgets to get the widget type into the widget. This is necessary to be able to tell the controller to layout into zones. Start work on information bar. Diffs (updated) ----- trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/applets/mediaplayer/mediaplayer.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.cpp 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/player.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h 1113370 trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp 1113370 Diff: http://reviewboard.kde.org/r/3552/diff Testing ------- Lots and lots. Seems to be quite slow, but I think that is a problem in the player. It always iterates over all the queue even if it should only show a picture. Thanks, Christophe _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
